Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment Issue While Editing Order Data containing Downlodable Products with "Links can be purchased separately" enabled in Admin Section #22298

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Alignment Issue While Editing Order Data containing Downlodable Products with "Links can be purchased separately" enabled in Admin Section #22298

merged 1 commit into from
Apr 20, 2019

Conversation

ansari-ziyaurrahman
Copy link
Contributor

Alignment Issue While Editing Order Data containing Downlodable Products with "Links can be purchased separately" enabled in Admin Section

Description (*)

Magento 2.3.x
Magento 2.2.x

Fixed Issues (if relevant)

  1. Alignment Issue While Editing Order Data containing Downlodable Products in Admin Section #20917: Alignment Issue While Editing Order Data containing Downlodable Products in Admin Section

Manual testing scenarios (*)

  1. Login into admin panel
  2. go to Order grid section from Sales > Orders
  3. Reorder any order containing downladable product with "Links can be purchased separately" enabled.
  4. now click on configure button : https://prnt.sc/navb8m
  5. A modal will display an alignment issue : https://prnt.sc/navble

Actual result (*)

https://prnt.sc/navble

Expected result (*)

https://prnt.sc/navc9o

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 12, 2019

Hi @ansari-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ansari-ziyaurrahman ansari-ziyaurrahman requested review from ronak2ram and dmytro-ch and removed request for dmytro-ch April 12, 2019 07:20
@ghost ghost assigned ronak2ram Apr 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-4744 has been created to process this Pull Request

@AlexWorking AlexWorking self-assigned this Apr 15, 2019
@ghost ghost unassigned AlexWorking Apr 15, 2019
@ghost
Copy link

ghost commented Apr 15, 2019

@AlexWorking unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@VasylShvorak VasylShvorak self-assigned this Apr 15, 2019
@VasylShvorak
Copy link
Contributor

✔️ QA passed

@nmalevanec nmalevanec self-assigned this Apr 16, 2019
@magento-engcom-team magento-engcom-team mentioned this pull request Apr 20, 2019
Closed
@magento-engcom-team magento-engcom-team merged commit 9e24d22 into magento:2.3-develop Apr 20, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2019

Hi @ansari-krish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Apr 20, 2019
@sidolov
ENGCOM-4744: Alignment Issue While Editing Order Data containing Down…
074e607 
…lodable Products with "Links can be purchased separately" enabled in Admin Section #22298
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 20, 2019
@deepakk-webkul deepakk-webkul mentioned this pull request May 2, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronak2ram ronak2ram ronak2ram approved these changes

Assignees

@ronak2ram ronak2ram

@nmalevanec nmalevanec

@VasylShvorak VasylShvorak

Labels
Area: Frontend Cleanup Component: Downloadable Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
7 participants
@ansari-ziyaurrahman @magento-engcom-team @VasylShvorak @ronak2ram @nmalevanec @dmytro-ch @AlexWorking